Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore putStream content-length requirement when transfer-encoding is chunked #323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccorcos
Copy link

@ccorcos ccorcos commented Jun 2, 2017

#322 @TooTallNate @rauchg

Now the following code works:

const request = require("request")

request.get(url)
	.on("response", (res) => {
		const req = client.putStream(res, "some/path", res.headers, function (err, res) {
			console.log(err, req.url)
		})
	})

@ccorcos
Copy link
Author

ccorcos commented Jun 2, 2017

Wait a second... I'm getting a 501 Not Implemented response...

@ccorcos
Copy link
Author

ccorcos commented Jun 2, 2017

Looks like this might be a better option for me: https://github.com/nathanpeck/s3-upload-stream

@devpascoe
Copy link

@ccorcos i tried that s3-upload-stream package too on a chunked stream i wanted to upload directly to s3 and its callback never ... called back. Tried all the libraries. How has no one run into this issue before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants